Remove Field parameter of FieldNumericalPropagator and FieldDSST propagator constructors

Orekit development
1

Hi all!

Since many years now, I find useless the final Field field parameter of the FieldDSSTPropagator and FieldNumericalPropagator constructors and class attributs. The field can be initialized from the FieldODEIntegrator<T> also required in both constructors (e.g., integrator.getCurrentSignedStepsize().getField()). Therefore, it could be intersting to simplify the constructors of both classes.

Since next version is a major release, what do you think about removing this parameter from FieldDSSTPropagator and FieldNumericalPropagator constructors?

Here a patch file showing what I would like to do :

patch.txt (3.7 KB)

Best regards,

Bryan

2 Likes
2

Sure, if the information can be retrieved from other parameters, we can use that.

3

+1
It’s actually safer to retrieve the Field internally because if it is passed too, the risk is that incompatible ones will be given. For instance, GradientField with different number of parameters

Cheers,
Romain.

1 Like
4

+1, I also think it will be safer this way :+1:

Cheers,
Vincent