Proposed renaming of Range(Rate) and class split

Orekit development
1

Hi folks,

my suggestion is to have OneWayRange(Rate) and TwoWayRange(Rate) in Orekit 14.0.
The rationale is that the naming would be clearer for the users, but also the code would be easier to understand for developpers/maintainers. With the current state of things, I find it quite difficult to mentally juggle with the fact that the emitter is not the same if it’s one or two-way.
Thoughts?

Cheers,
Romain.

2

Note that there is a merge request from Brianna currently under review that also changes things quite a bit on measurements hierarchy.

3

I would have no objection, and the implementation would be fairly trivial (basically add one more measurement class and rewrite the unit tests). Maybe you could check out my branch and make the addition there, and that way ideally we could get both changes into v14? It would also get someone else’s eyes on my MR, which is fairly “review ready” now and as Luc says, has pretty considerable changes.

4

Hi,

If your MR is substantial already, let’s not add this, it can be its own thing afterwards

Cheers,
Romain.