Dear Orekit users,
I think we have enough bugs resolved or about to be to do a patch very soon.
Check out the milestone.
I should be able to take care of the release before the end of the year.
Cheers,
Romain.
4 Likes
Hi!
The last week of January will be free for me. I can do the 13.1.3 release with the issues already resolved. What do you think?
Bryan
2 Likes
Yes 13.1.3 would be nice as 14.0 will probably be delayed a bit.
Hi guys,
The delay is not so much the release itself, but the fact that there is still an issue being fixed by @Vincent
Since 13.1 is kind of an LTS, it’s important it’s done I think.
Cheers,
Romain.
Hey everyone,
Sorry for the delay, a bit of a chaos at work at this moment. I’m going to finish it today.
Cheers,
Vincent
2 Likes
If there is time, I’d like to include the fix for this bug I discovered while trying to update some code to use the more accurate TimeOffset instead of double: Incorrect time scale used in parseDataRecord (#1891) · Issues · Orekit / Orekit · GitLab. I’ve fixed the bug, which is less than 1 ms of difference, and added test cases for it, but it seems that a large number of other Orekit tests are now failing. I’ve started trying to address some of those, but I’m still working through that. You can see my progress in this MR: Improve time accuracy in CelestialBodies #1891 (!1065) · Merge requests · Orekit / Orekit · GitLab
3 Likes
OK, now Improve time accuracy in CelestialBodies #1891 (!1065) · Merge requests · Orekit / Orekit · GitLab should be ready to merge after Fix NaN when computing lighting ratio #1892 (!1068) · Merge requests · Orekit / Orekit · GitLab is merged for ConicallyShadowedListFluxModel can return NaN (#1892) · Issues · Orekit / Orekit · GitLab, which I discovered while fixing #1891. To make it into 13.1.3, should they be merged into develop, or a separate branch?
Regards,
Evan
They’re merged now. Thanks!
Thanks for the fixes. I’ll try to cherry pick em up from the patch branch.
The cherry picking is not going well, I’ve got over twenty tests in failure. Next time it’d be really easier to do the fix on the patch branch please.
Hi!
I planned to start the patch on Monday. Is it okay for you?
If there is still small things to do on the patch branc, I can handle them on Monday (I’ll have the time to do it)
If they are still issues to be fixed and not started, I propose we postpone them to 13.1.4. Since 13.1 is an LTS version, 13.1.4 version will for sure be released one day.
Bryan
1 Like
Hey y’all,
I’ve cleaned things up, the patch branch is ready to start the release process.
Cheers,
Romain.
I’m merging the main branch into develop.
Could you please do not merge into develop until the merging process is finished?
Small update:
- Merge is done
- Conflicts are resolved
- Code compilation is OK
- I just have 4 tests that do not pass
I’m fixing the 4 tests, after that I’ll be able to push develop
1 Like
develop is green, merge is open!
2 Likes