Need urgent fix for issue 1704

Orekit development
1

Hi everyone,

I have encountered a huge bottleneck in heavy duty computations involving NeQuick ionospheric model. This corresponds to issue 1704.
At my day job, I need this fix very urgently (read: now) and I need it to be officially published.

As this fix is not really a bug but an improvement and as it deprecates some methods, I cannot consider it is a patch that can be released without a vote.

Would you mind if I perform a release for 13.1, including the fix for this issue, and perhaps @Serrof issue 1702 if it is ready?

2

Hello @luc,

I guess you cannot use a different branch with what you need so that you can use it right now ?

My thoughts are the followings:

  • I would not deprecate APIs as it could lead to failure in some pipelines. We would have to create an issue as a reminder for the next release.

  • Also, it would not be the first time that there is an improvement in a patch so i would not be bothered by this being a patch.

Cheers,
Vincent

3

Hi @luc,

If it’s so urgent and corrects a performance issue I don’t mind if you release it as a patch.
You can remove the “deprecation” flag and open an issue to deprecate the constructors for the next minor/major release.
Do we have an official policy (ie. minor vs major) for deprecation?

Maxime

4

Hi Luc,

I think that could still qualify for a patch.

To answer your question on issue 1702 it is closed and ready for release.

Cheers,
Romain

5

I can’t… I need to release something to a customer and it needs to be based on released versions.

Well, deprecation is a way to nudge developers without breaking code, pipelines should not fail with deprecation, they should just issue mire warnings.

I did not expect two answers like that! Thanks a lot, that is a relief.

I will wait just a few hours more in case someone chimes in and if nobody complains, I’ll issue a patch. I will remove the deprecation flags and update the @since and change.xml.

2 Likes
6

I agree with the patch release for this fix

Concerning issue 1702, it looks like a new feature and shall wait next minor release, right?

1 Like
7

I will only include the fix for 1704, then.

1 Like
8

Sorry I did not answer that.
What we did up to now is we introduce deprecation in minor versions because they don’t break source compatibility and remove them in major versions.

1 Like