Hi folks,
I believe that AttitudeProvider should inherit from EventDetectorsProvider, as the attitude can induce singularities where you want to RESET_DERIVATIVES. I’m thinking in particular of AggregateBoundedAttitudeProvider, which should probably set up a bunch of (Field)DateDetector. I don’t think we can trust the user to do that themselves. Obviously (Field)Propagator would then incorporate them.
Thoughts?
Cheers,
Romain.
I’m not sure I understand.
For me, AttitudeProvider is really low level (just like PVCoordinatesProvider).
For sure, AggregateBoundedAttitudeProvider is much higher level and could benefit from EventDetectorsProvider, but not AttitudeProvider IMHO.
If AttitudeProvider inherited from EventDetectorsProvider (with the default implementation of no detectors), then it could be used exactly like ForceModel in (Field)NumericalPropagator to feed them, without the need for any cast.
Cheers,
Romain.
OK, I get it.
+1 for the change
Sweet I’ll open an issue and put it in the 13.0 milestone
The issue is closed following a MR. I actually beliebe this could simplify the use of AttitudesSequence? Basically the method registerSwitchEvents could be deprecated if the Switches were retrived by getEventDetectors, am I right?
Cheers,
Romain.