Hi folks,
I was wondering, why does ImpulseManeuver require the trigger handler to return Action.STOP in order to actually apply the burn? This sounds rather arbitrary and it prevents from using it with RecordAndContinue as the latter always returns CONTINUE.
Cheers,
Romain.
It is indeed arbitrary, my bad 
No worries, so shall we accept any Action from the trigger’s handler then (it would be replaced by RESET_STATE anyway)?
Still on that class, I wonder if it should really inherit from AbstractDetector. This forces to implement a create method, allowing the user to pass any EventHandler, which would cause the maneuver not to be applied, as only the local one works properly. So shouldn’t it just inherit from EventDetector?
Cheers,
Romain.
Yes, I think you are right.
You could try it and if all tests pass then it is a proof it is legit.
It checks out (see MR). I’ll add tests on the Action