Thank you Luc for your work on the script & the release.
Regarding the release, I checked:
Checkstyle: no issues
SpotBugs: one non-blocking issue
Bug Category Details Line Priority Redundant nullcheck of stream, which is known to be non-null in org.orekit.utils.OrekitConfiguration.getOrekitVersion() STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE71 Medium
Tests: 0 failure
Warnings during compilation (jdk 8): total of 6 warnings (unchecked cast + unchecked generic array creation for varargs parameter). Non blocking for the release
Warnings during javadoc generation: 1 false alarm, it mentions an error when fetching URL: Overview (Hipparchus 4.0.1 API) but the link works fine ?
Yes, I know about this one. For now, I kept it for the sake of defensive programming. The stream is non-null as long as source tree remains consistent (i.e. as long as the orekit.properties file is found). We could remove the check if we consider removing this properties file would be a programming error.
It seems I cannot find a way to have both checkstyle, the IDE, and SonarQube happy about all of these. It seems sometimes I can remove the warnings with some @supresswarning, but sometimes another tool is not happy because it considers the annotation is unneeded, this is an endless loop.
This one is new to me, I did not notice it. Perhaps some proxy blocking effect that does not appear when following the link with a browser?
Impressive list of improvements for a minor version!
Are you sure that the API is not broken versus 13.0, for the following modification: “Move Lambert solver in dedicated package and wrap it for IOD” ?
Yes, it should be compatible.
It corresponds to merge request 812.
The existing API is still available, and public methods have been declared deprecated (which we allow for non-major releases).
The site has been generated correctly, but the link to the directory has not been created. This link will be created when the Orekit website will be updated to include the new version.
I tried to update the site, but it seems the CI/CD does not pick up anymore the latest version.
Looking at the download page in the staging site leads to broken links.
I guess the changes I made to the CI/CD had a nasty side effect…
Could someone more fluent than me with this stuff have a look?