Hello,
Thanks @yannick !
I have been warned that a test failed (that’s great to be in a short loop ).
I will push the fix tomorrow.
Best regards.
Hello,
Thanks @yannick !
I have been warned that a test failed (that’s great to be in a short loop ).
I will push the fix tomorrow.
Best regards.
Hello,
@evan.ward While fixing the pipeline error, I found about the localized message.
I will push with the use of OrekitMessages.
Best regards,
Anne-Laure
Hi all,
I have pushed the changes to the issue-797
branch of the Orekit repository.
Regards
Yannick
Hello @evan.ward ,
The pipeline is red again but this time because of missing translated message.
I could provide french :
# {0} failed to find root between {1} (g={2}) and {3} (g={4}) : {5}\nLast iteration at {6} (g={7})
FIND_ROOT={0} n'a pas réussi à trouver une solution entre {1} (g={2}) et {3} (g={4}) : {5}\nLa dernière itération était à {6} (g={7})
and spanish :
# {0} failed to find root between {1} (g={2}) and {3} (g={4}) : {5}\nLast iteration at {6} (g={7}) FIND_ROOT={0} ha fallado buscando una solución entre {1} (g={2}) y {3} (g={4}) : {5}\nÚltima iteración en {6} (g={7})
I do not know how you handle all the langages ?
This branch is in your hands ? Or do you think I could do more ?
Best regards.
Thanks! I’ll take a look.
I just put in <MISSING TRANSLATION>
and let someone who knows the language fill it in later. Before a release Luc usually asks the community to update translations.
Anne-Laure, the next time, you can create your own fork of the Orekit project on Gitlab, push your code in a dedicated branch in your fork and, then, create a merge request to the develop branch of Orekit project. We can give you an access to the Gitlab CI runner executor or, at your convenience, you could enroll your own executor.
Do not hesitate to ask me for more detailed information in private if necessary.
I have followed the steps from contribution guide.
Now my branch is created but still failing:
There has been a timeout failure or the job got stuck. Check your timeout limits or try again
Do you have access to more details ?
Hi @Anne-Laure
On your fork it’s normal. It’s because by default Orekit’s forks are not connected to the Continuous Integration worker.
I know that it’s possible to connect it to the worker, but we need the intervention of our Gitlab expert @sdinot
Bryan
Oups,I’m really sorry, I had completely missed the rest of this exchange. When I don’t answer, don’t hesitate to ask me again!
I just allowed your clone to use one of our runners.
And I am back… after few weeks again… Sorry!
I have rebased my branch on develop to be up to date.
I have completed the MISSING TRANSLATION in all language files.
I have replaced the embed exception with supressed exception as you requested, now the trace is :
org.orekit.errors.OrekitException: maximal count (5) exceeded
at org.orekit.errors.OrekitException.unwrap(OrekitException.java:154)
at org.orekit.propagation.analytical.AbstractAnalyticalPropagator.propagate(AbstractAnalyticalPropagator.java:186)
at org.orekit.propagation.AbstractPropagator.propagate(AbstractPropagator.java:186)
at org.orekit.propagation.events.EventDetectorTest.testException(EventDetectorTest.java:335)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:221)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
Caused by: org.hipparchus.exception.MathIllegalStateException: maximal count (5) exceeded
at org.hipparchus.util.Incrementor.lambda$static$0(Incrementor.java:41)
at org.hipparchus.util.Incrementor.increment(Incrementor.java:238)
at org.hipparchus.analysis.solvers.BaseAbstractUnivariateSolver.incrementEvaluationCount(BaseAbstractUnivariateSolver.java:318)
at org.hipparchus.analysis.solvers.BaseAbstractUnivariateSolver.computeObjectiveValue(BaseAbstractUnivariateSolver.java:165)
at org.hipparchus.analysis.solvers.BracketingNthOrderBrentSolver.doSolveInterval(BracketingNthOrderBrentSolver.java:297)
at org.hipparchus.analysis.solvers.BracketingNthOrderBrentSolver.solveInterval(BracketingNthOrderBrentSolver.java:426)
at org.hipparchus.analysis.solvers.BracketedUnivariateSolver.solveInterval(BracketedUnivariateSolver.java:126)
at org.orekit.propagation.events.EventState.findRoot(EventState.java:323)
at org.orekit.propagation.events.EventState.evaluateStep(EventState.java:220)
at org.orekit.propagation.analytical.AbstractAnalyticalPropagator.acceptStep(AbstractAnalyticalPropagator.java:237)
at org.orekit.propagation.analytical.AbstractAnalyticalPropagator.propagate(AbstractAnalyticalPropagator.java:172)
... 28 more
Suppressed: org.orekit.errors.OrekitException: a-fake-detector failed to find root between 2011-05-11T00:00:00.000 (g=1.000e+00) and 2011-05-11T00:01:39.178 (g=-1.000e+00) : maximal count (5) exceeded
Last iteration at 2011-05-11T00:00:00.000 (g=1.000e+00)
at org.orekit.propagation.events.EventState.findRoot(EventState.java:351)
... 31 more
[CIRCULAR REFERENCE:org.hipparchus.exception.MathIllegalStateException: maximal count (5) exceeded]
While running tests, I have found a duplicated message in the italian file so I fixed that in a separate commit (don’t know if it passes on develop?).
Thanks @sdinot for letting me use the gitlab pipeline, it helped a lot!
Still, my branch is failure because it can not execute sonar, maybe because I am on a fork ?
I don’t know if this could be merged before 11.0 release ? I have seen that it is in discussion…
Best regards,
Anne-Laure
You are welcome!
You are right, but here is how to solve this problem:
SONAR_TOKEN
. The value of this variable must be the value of the token provided by SonarQube. Check the “Mask variable” option and click on “Add variable”.master
branch. You can cause this by manually triggering a pipeline:
master
branch → Run pipeline → Wait half an hour MAVEN_CLI_OPTS
variable (defined in the CI script). Just before clicking on the final “Run pipeline”, state that MAVEN_CLI_OPTS
variable value is:-s .CI/maven-settings.xml --batch-mode --errors --fail-at-end --show-version -DinstallAtEnd=true -DdeployAtEnd=true -Dsonar.projectKey="Anne-Laure/orekit" -Dsonar.projectName="Orekit (Anne-Laure/orekit)"
In fact, this is the default value of the MAVEN_CLI_OPTS
variable, increased by the following parameters:-Dsonar.projectKey="Anne-Laure/orekit" -Dsonar.projectName="Orekit (Anne-Laure/orekit)"
Then, run the pipeline and wait half an hour.master
or release-10.3
branches, you have to override the MAVEN_CLI_OPTS
variable as on the master
branch.Sébastien
Hello,
Thank you for your advice. I have followed the first steps.
I have tried to run master at the moment and it worked (with simple quote).
Still my branch is RED after that maybe because I need to wait for 11.0 release ?
@sdinot Do I understand well that I could not run sonar on my branch until 11.0 is released ?
Best regards,
Anne-Laure
We would be very happy to include this contribution in the 11.0 release.
Sorry, but I am afraid that the workaround I provided does not work because of the following command line in the CI script.
- mvn $MAVEN_CLI_OPTS sonar:sonar -Dsonar.login=${SONAR_TOKEN} -Dsonar.branch.name=${CI_COMMIT_REF_NAME}
In fact, the initial submission should not specify a branch while the above command does. So you have no choice but to initiate this first solution from your workstation:
cd orekit-repository
git switch master
export JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64
mvn -s .CI/maven-settings.xml --batch-mode --errors --fail-at-end \
--show-version -DinstallAtEnd=true -DdeployAtEnd=true verify site
export SONAR_TOKEN=<your-sonarqube-token>
export CI_PROJECT_TITLE=Orekit
export CI_PROJECT_NAMESPACE=<your-namespace>
export CI_PROJECT_NAME=orekit
export SONAR_PROJECT_KEY="${CI_PROJECT_NAMESPACE}:${CI_PROJECT_NAME}"
export SONAR_PROJECT_NAME="${CI_PROJECT_TITLE} (${CI_PROJECT_NAMESPACE}:${CI_PROJECT_NAME})"
mvn -s .CI/maven-settings.xml --batch-mode --errors --fail-at-end \
--show-version -DinstallAtEnd=true -DdeployAtEnd=true sonar:sonar \
-Dsonar.login=$SONAR_TOKEN -Dsonar.projectKey="$SONAR_PROJECT_KEY" \
-Dsonar.projectName="$SONAR_PROJECT_NAME"
Of course, this only works if Maven can connect to the Orekit SonarQube server from your workstation.
I apologize for the lost time, but in my defense, SonarQube is really a fussy software…
I know integration can be hard, even if I have never used Sonar, that’s totally fine!
As you quote, it does not work from my side as I am not connected to the network…
To sumup :
Best regards,
Anne-Laure
I think that I can initialize your project on SonarQube for you. Do you agree?
Since I had a little time to devote to this problem tonight and won’t have much tomorrow, I took the liberty of :
Here is the report.
And I just restarted the last failed pipeline on your working branch.