Asking for help about Gitlab pipeline failure?

Orekit development
1

Recently I have tried to contribute a fix for issue-778, and blocked by CI/CD pipeline failure.

sonarQube complains about bugs in TimeSpanMap.java/FieldTimeSpanMap.java, which is not relevant to my commit. More confused is that my clone of develop branch is also failed, while the orekit/develop shows success in CI/CD.

Can some of orekit developers give me some suggestions?

2

No idea @xzguo, the incriminated code dates back from 2022…
Sometimes Sonar is buggy.
I’ve tried changing the policy on “New Code” on your Sonar.

  • “main” is compared to previous version
  • “develop” is compared to “main”
  • “issue-778” is compared to “develop”

(I wonder if you can change that from your side when logged in Sonar ?)

I have relaunched the pipeline on your MR, we’ll see if it fixes thing.

3

All good @xzguo: pipeline is green with 0 bug, 0 code smell and 100% coverage !
Well done!

4

thanks, @MaximeJ .

Is the sonar policy changes always effective now and after? Or do I still need to log and do some changes in my Sonar account? Sorry for that I lack experience using Sonar, I can’t locate the relevant Policy settings.

Hopefully the MR issue-778 could be merged.

5

You’re very welcome @xzguo

Yes, now your new branches are analyzed with respect to “develop”.

Only if you need to change policy for a branch. For example if you’re doing a bug fix for a patch release, then you will need to setup “main” as your comparison branch instead of “develop”.

Cheers,
Maxime